8000 fix(sdk): serialization of Map in sub-objects of inputs and outputs by nirga · Pull Request #323 · traceloop/openllmetry-js · GitHub
[go: up one dir, main page]
Skip to content

fix(sdk): serialization of Map in sub-objects of inputs and outputs #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2024
Merged

fix(sdk): serialization of Map in sub-objects of inputs and outputs #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 26 additions & 11 deletions packages/traceloop-sdk/src/lib/tracing/decorators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,13 @@ function withEntity<
) {
span.setAttribute(
SpanAttributes.TRACELOOP_ENTITY_INPUT,
JSON.stringify({ args: [], kwargs: input[0] }),
serialize({ args: [], kwargs: input[0] }),
);
} else {
span.setAttribute(
SpanAttributes.TRACELOOP_ENTITY_INPUT,
JSON.stringify({
args: input.map((arg) =>
arg instanceof Map ? Array.from(arg.entries()) : arg,
),
serialize({
args: input,
kwargs: {},
}),
);
Expand All @@ -107,12 +105,13 @@ function withEntity<
serialize(resolvedRes),
);
}
return resolvedRes;
} catch (error) {
Telemetry.getInstance().logException(error);
} finally {
span.end();
}

return resolvedRes;
});
}
try {
Expand All @@ -122,12 +121,13 @@ function withEntity<
serialize(res),
);
}
return res;
} catch (error) {
Telemetry.getInstance().logException(error);
} finally {
span.end();
}

return res;
},
),
);
Expand Down Expand Up @@ -248,10 +248,25 @@ export function tool(
return entity(TraceloopSpanKindValues.TOOL, config ?? {});
}

function serialize(input: unknown): string {
function cleanInput(input: unknown): unknown {
if (input instanceof Map) {
return JSON.stringify(Array.from(input.entries()));
} else {
return JSON.stringify(input);
return Array.from(input.entries());
} else if (Array.isArray(input)) {
return input.map((value) => cleanInput(value));
} else if (!input) {
return input;
} else if (typeof input === "object") {
// serialize object one by one
const output: any = {};
Object.entries(input as any).forEach(([key, value]) => {
output[key] = cleanInput(value);
});
return output;
}

return input;
}

function serialize(input: unknown): string {
return JSON.stringify(cleanInput(input));
}
18 changes: 9 additions & 9 deletions packages/traceloop-sdk/test/decorators.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,10 +233,10 @@ describe("Test SDK Decorators", () => {
class TestOpenAI {
constructor(private model = "gpt-3.5-turbo") {}

@traceloop.workflow((thisArg, things) => ({
@traceloop.workflow((thisArg, { things }) => ({
name: `${(thisArg as TestOpenAI).model}_${(things as Map<string, string>).get("joke")}`,
}))
async chat(things: Map<string, string>) {
async chat({ things }: { things: Map<string, string> }) {
const generations: Map<string, string> = new Map();
for await (const [key, value] of things) {
const chatCompletion = await openai.chat.completions.create({
Expand All @@ -256,12 +256,12 @@ describe("Test SDK Decorators", () => {
}

const testOpenAI = new TestOpenAI();
const result = await testOpenAI.chat(
new Map([
const result = await testOpenAI.chat({
things: new Map([
["joke", "OpenTelemetry"],
["fact", "JavaScript"],
]),
);
});

const spans = memoryExporter.getFinishedSpans();
const workflowName = "gpt-3.5-turbo_OpenTelemetry";
Expand All @@ -287,13 +287,13 @@ describe("Test SDK Decorators", () => {
assert.strictEqual(
workflowSpan.attributes[`${SpanAttributes.TRACELOOP_ENTITY_INPUT}`],
JSON.stringify({
args: [
[
args: [],
kwargs: {
things: [
["joke", "OpenTelemetry"],
["fact", "JavaScript"],
],
],
kwargs: {},
},
}),
);
assert.strictEqual(
Expand Down
Loading
0