fix: use mem::swap on cloned inner service #561

tomharmon · 2025-04-24T00:48:12Z

Motivation

Without this change the inner service may panic! since the cloned service may not be the ready service as described in
the tower docs

Use std::mem::replace to swap the ready and cloned services

tower-http/src/auth/async_require_authorization.rs

In the `AsyncRequireAuthorization` service, the cloned service could be different than the ready service due to the complexities described here: https://docs.rs/tower/latest/tower/trait.Service.html#be-careful-when-cloning-inner-services so this commit fixes it by using std::mem::replace as recommended in the documentation

jplatte · 2025-04-24T18:09:39Z

Thanks!

tomharmon force-pushed the fix/auth-clone-issue branch from cc5107a to 5c769b5 Compare April 24, 2025 00:48

jplatte reviewed Apr 24, 2025

View reviewed changes

tower-http/src/auth/async_require_authorization.rs Outdated Show resolved Hide resolved

tomharmon force-pushed the fix/auth-clone-issue branch from 5c769b5 to 72670ea Compare April 24, 2025 16:44

tomharmon force-pushed the fix/auth-clone-issue branch from 72670ea to a5226e9 Compare April 24, 2025 16:45

tomharmon changed the title ~~fix: use mem::replace on cloned inner service~~ fix: use mem::swap on cloned inner service Apr 24, 2025

jplatte approved these changes Apr 24, 2025

View reviewed changes

jplatte merged commit 45ce10b into tower-rs:main Apr 24, 2025
11 checks passed