[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ask ai panel not auto flip #7284

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix: ask ai panel not auto flip #7284

merged 1 commit into from
Jun 20, 2024

Conversation

L-Sun
Copy link
Contributor
@L-Sun L-Sun commented Jun 20, 2024 •
edited
Loading

Close AF-928

The CSS rule for portal content uses position: absolute which causes the portal size to become zero. As a result, the computePosition function returns incorrect results.

Before:
image.png

After:
image.png

@graphite-app Graphite App
Copy link
graphite-app bot commented Jun 20, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@L-Sun Graphite App
Copy link
Contributor Author
L-Sun commented Jun 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @L-Sun and the rest of your teammates on Graphite Graphite

@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Jun 20, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1a8bbc6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@L-Sun L-Sun marked this pull request as ready for review June 20, 2024 07:20
@codecov Codecov
Copy link
codecov bot commented Jun 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.27%. Comparing base (1fdfa83) to head (1a8bbc6).

Additional details and impacted files 
@@            Coverage Diff             @@
##           canary    #7284      +/-   ##
==========================================
- Coverage   58.33%   58.27%   -0.06%     
==========================================
  Files         837      837              
  Lines       36541    36541              
  Branches     3919     3918       -1     
==========================================
- Hits        21315    21296      -19     
- Misses      14933    14952      +19     
  Partials      293      293
Flag Coverage Δ
server-test 77.44% <ø> (-0.09%) ⬇️
unittest 29.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@L-Sun L-Sun requested a review from fundon June 20, 2024 07:23
@graphite-app Graphite App
Copy link
graphite-app bot commented Jun 20, 2024 •
edited
Loading

Merge activity

@L-Sun L-Sun force-pushed the 06-20-fix_ask_ai_panel_not_auto_flip branch from ed4c6a2 to 1a8bbc6 Compare June 20, 2024 07:33
@graphite-app graphite-app bot merged commit 1a8bbc6 into canary Jun 20, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 06-20-fix_ask_ai_panel_not_auto_flip branch June 20, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fundon fundon fundon approved these changes

Assignees
No one assigned
Labels
app:core
Projects
AFFiNE Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@L-Sun @fundon