[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ai chat bugs #7283

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix(core): ai chat bugs #7283

merged 1 commit into from
Jun 20, 2024

Conversation

fundon
Copy link
Contributor
@fundon fundon commented Jun 20, 2024

Closes: AF-929

  • remove icon background on chat-input
  • activate the selected card immediately
  • fix quote when selecting Start with this doc
  • clear candidate card list when switching doc
Screen.Recording.2024-06-20.at.15.50.57.mov

Copy link
graphite-app bot commented Jun 20, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author
fundon commented Jun 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

Copy link
nx-cloud bot commented Jun 20, 2024

Copy link
codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 28.98%. Comparing base (b99e8b1) to head (dbd678c).

Files Patch % Lines
...src/blocksuite/presets/ai/chat-panel/chat-cards.ts 0.00% 28 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7283       +/-   ##
===========================================
- Coverage   58.28%   28.98%   -29.30%     
===========================================
  Files         838      646      -192     
  Lines       36551    14492    -22059     
  Branches     3919     2543     -1376     
===========================================
- Hits        21302     4200    -17102     
+ Misses      14956    10046     -4910     
+ Partials      293      246       -47     
Flag Coverage Δ
server-test ?
unittest 28.98% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon marked this pull request as ready for review June 20, 2024 07:47
@fundon fundon force-pushed the 06_20-fix-ai-chat-bugs branch 3 times, most recently from 2641b9c to 2e79a98 Compare June 20, 2024 10:07
@graphite-app graphite-app bot requested review from EYHN and forehalo June 20, 2024 11:03
Copy link
Contributor
@L-Sun L-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Copy link
graphite-app bot commented Jun 20, 2024

Merge activity

Closes: [AF-929](https://linear.app/affine-design/issue/AF-929/continue-with-ai-点击后应当是立即激活选区)

* [x] remove icon background on `chat-input`
* [x] activate the selected card immediately
* [x] fix quote when selecting `Start with this doc`
* [x] clear candidate card list when switching doc

https://github.com/toeverything/AFFiNE/assets/27926/706d499e-b738-4bb4-9353-510f73613875
@graphite-app graphite-app bot merged commit dbd678c into canary Jun 20, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 06_20-fix-ai-chat-bugs branch June 20, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants