[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove tree shaking #7271

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

L-Sun
Copy link
Contributor
@L-Sun L-Sun commented Jun 19, 2024

remove sideEffects field from frontend/core/packages.json

Copy link
graphite-app bot commented Jun 19, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author
L-Sun commented Jun 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @L-Sun and the rest of your teammates on Graphite Graphite

@L-Sun L-Sun requested a review from pengx17 June 19, 2024 07:41
Copy link
nx-cloud bot commented Jun 19, 2024

@L-Sun L-Sun marked this pull request as ready for review June 19, 2024 07:42
@L-Sun L-Sun requested a review from Brooooooklyn June 19, 2024 07:42
@L-Sun L-Sun force-pushed the 06-19-chore_remove_tree_shaking branch from 35b086f to a68ae32 Compare June 19, 2024 07:43
Copy link
codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.54%. Comparing base (bcc6642) to head (84ad236).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7271      +/-   ##
==========================================
+ Coverage   59.49%   59.54%   +0.04%     
==========================================
  Files         847      847              
  Lines       37922    37922              
  Branches     3957     3958       +1     
==========================================
+ Hits        22561    22579      +18     
+ Misses      15066    15048      -18     
  Partials      295      295              
Flag Coverage Δ
server-test 78.57% <ø> (+0.07%) ⬆️
unittest 28.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
graphite-app bot commented Jun 19, 2024

Merge activity

remove `sideEffects` field from `frontend/core/packages.json`
@L-Sun L-Sun force-pushed the 06-19-chore_remove_tree_shaking branch from a68ae32 to 84ad236 Compare June 19, 2024 07:57
@graphite-app graphite-app bot merged commit 84ad236 into canary Jun 19, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 06-19-chore_remove_tree_shaking branch June 19, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants