[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: page list supports preview #2606

Merged
merged 1 commit into from
May 31, 2023
Merged

feat: page list supports preview #2606

merged 1 commit into from
May 31, 2023

Conversation

lawvs
Copy link
Collaborator
@lawvs lawvs commented May 30, 2023

Screenshot 2023-05-31 at 12 29 11 AM

See also #2603

@codesandbox
Copy link
codesandbox bot commented May 30, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link
vercel bot commented May 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2023 4:29am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2023 4:29am

@cloudflare-workers-and-pages
Copy link
cloudflare-workers-and-pages bot commented May 30, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e5bcea4
Status: ✅  Deploy successful!
Preview URL: https://8e66411d.affine.pages.dev
Branch Preview URL: https://feat-page-preview.affine.pages.dev

View logs

@lawvs lawvs temporarily deployed to development May 30, 2023 16:28 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 30, 2023 16:28 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 30, 2023 16:28 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 30, 2023 16:28 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 30, 2023 16:28 — with GitHub Actions Inactive
@lawvs lawvs requested a review from himself65 May 30, 2023 16:29
@lawvs lawvs temporarily deployed to development May 30, 2023 16:31 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 30, 2023 16:33 Inactive
@lawvs lawvs temporarily deployed to development May 30, 2023 16:33 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 30, 2023 16:33 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 30, 2023 16:33 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 30, 2023 16:33 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 30, 2023 16:33 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 30, 2023 16:33 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 30, 2023 16:33 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 30, 2023 16:33 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 30, 2023 16:38 Inactive
@perfsee
Copy link
perfsee bot commented May 30, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …/page-preview                 +/- ##
===================================================================
< Bundle               4.2 MB         4.2 MB      +320 B(+0.01%)   
< Initial JS          2.22 MB        2.22 MB      +320 B(+0.01%)   
= Initial CSS         75.7 kB        75.7 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   75             75                       
= Chunks                   58             58                       
= Packages                198            198                       
= Duplicates               14             14                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …/page-preview                 +/- ##
===================================================================
< Bundle              4.08 MB        4.08 MB      +320 B(+0.01%)   
< Initial JS           2.1 MB         2.1 MB      +320 B(+0.02%)   
= Initial CSS         75.7 kB        75.7 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   73             73                       
= Chunks                   56             56                       
= Packages                198            198                       
= Duplicates               14             14                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …/page-preview                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@codecov
Copy link
codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.01 🎉

Comparison is base (1c7ae04) 68.66% compared to head (e5bcea4) 68.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2606      +/-   ##
==========================================
+ Coverage   68.66%   68.67%   +0.01%     
==========================================
  Files         336      336              
  Lines        7685     7691       +6     
  Branches     1235     1237       +2     
==========================================
+ Hits         5277     5282       +5     
  Misses       2140     2140              
- Partials      268      269       +1     
Flag Coverage Δ
e2etest 62.41% <60.00%> (+0.05%) ⬆️
e2etest-macos-latest-x64 ?
e2etest-ubuntu-latest-x64 45.33% <40.00%> (-0.07%) ⬇️
e2etest-windows-latest-x64 ?
server-test 73.12% <ø> (ø)
storybook-test 50.04% <100.00%> (+0.12%) ⬆️
unittest 51.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/component/src/components/page-list/all-page.tsx 85.36% <ø> (ø)
...ponent/src/components/page-list/all-pages-body.tsx 95.83% <ø> (ø)
...src/components/page-list/components/title-cell.tsx 87.50% <50.00%> (-12.50%) ⬇️
...kages/component/src/components/page-list/styles.ts 91.66% <100.00%> (+4.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lawvs lawvs temporarily deployed to development May 31, 2023 04:06 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 31, 2023 04:06 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 31, 2023 04:06 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 31, 2023 04:06 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 31, 2023 04:06 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 31, 2023 04:09 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 31, 2023 04:12 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 31, 2023 04:12 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 31, 2023 04:12 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 31, 2023 04:12 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 31, 2023 04:12 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 31, 2023 04:12 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 31, 2023 04:12 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 31, 2023 04:12 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 31, 2023 04:24 Inactive
@himself65 himself65 enabled auto-merge (squash) May 31, 2023 04:24
@himself65 himself65 merged commit 855fd8a into master May 31, 2023
@himself65 himself65 deleted the feat/page-preview branch May 31, 2023 04:24
@vercel vercel bot temporarily deployed to Preview – affine-preview May 31, 2023 04:29 Inactive
himself65 pushed a commit that referenced this pull request May 31, 2023
himself65 pushed a commit that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants