8000 feat: add selected model store with click for selecting logic by toddeTV · Pull Request #28 · toddeTV/zlig · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add selected model store with click for selecting logic #28

Merged
merged 51 commits into from
Aug 16, 2024
Merged

feat: add selected model store with click for selecting logic #28

merged 51 commits into from
Aug 16, 2024

Conversation

toddeTV
Copy link
Owner
@toddeTV toddeTV commented Jul 23, 2024 •
edited
Loading

Resolves #16

No outline effect, see #16 (comment)

toddeTV and others added 22 commits July 14, 2024 23:54
@toddeTV
feat: add test scene
f240fe2
@toddeTV
Merge branch 'dev' into feat/3d-node-click-poc
c3b4d6b
@toddeTV
fix: TresJS dependency version upgrade bc the current one had a bug
a924f5a
@toddeTV
feat: add dependency @tresjs/post-processing
637e067
@toddeTV
feat: add pinia store for storing the current clicked & active model
ffb0f6e
@toddeTV
feat: clicking a model node will store the model UUID in the pinia store
2ccaae4
@fehnomenal
create script to generate types for gltf models
42a199b
@fehnomenal
rework script
3284cca
@fehnomenal
generate model types also on build
3d2956f
@fehnomenal
generate types for models in assets
fefb2ee
@fehnomenal
add vite plugin to bundle model files
b963ccf
@fehnomenal
inline hardcoded default values
16c8826
@fehnomenal
Merge branch 'dev' into feat/typed-models
9237295
@fehnomenal
lint
075e5df
@toddeTV
Merge branch 'dev' into feat/typed-models
3c7ebe7
@toddeTV
feat: add documentation to README.md
806d057
@toddeTV
refactor: changing pnpm command script names
cb9507c
@toddeTV
refactor: lint
0845571
@toddeTV
refactor: nit doc comment length
9c3b636
@toddeTV
Merge branch 'dev' into feat/3d-node-click-poc
dd1db4f
@toddeTV
Merge branch 'feat/typed-models' into feat/3d-node-click-poc
1b03dda
@toddeTV
chore: remove not needed test scene model
eb5fd29
@toddeTV toddeTV self-assigned this Jul 23, 2024
@vercel Vercel
Copy link
vercel bot commented Jul 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zlig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 6:44pm

@toddeTV
Copy link
Owner Author
toddeTV commented Aug 12, 2024

@fehnomenal
The updates are ready for review.

Summary of Changes:

  • Model Registration: Models can now register themselves to be available for selection. Only registered models can be selected by the user.
  • Single Model Selection: The system now allows only one model to be selected at a time.
  • Model Storage: The selected model is stored as an object, not just by its ID. However, for registered models, only the IDs are stored to optimize performance.
  • Additional Enhancements: I’ve added several helper functions and renamed some files for better organization.
  • ... And more. See my commits :)

@toddeTV toddeTV requested a review from fehnomenal August 12, 2024 17:41
@toddeTV toddeTV changed the title feat: add model node click with selected node store feat: add selected model store with click for selecting logic Aug 12, 2024
8000
@toddeTV toddeTV removed the request for review from fehnomenal August 12, 2024 18:33
@toddeTV toddeTV requested a review from fehnomenal August 12, 2024 18:44
This was referenced Aug 12, 2024
Closed
Closed
fehnomenal
fehnomenal approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator
@fehnomenal fehnomenal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is clear and I have no objections. Keep up the pace 🚀

@toddeTV toddeTV merged commit 1c90c6c into dev Aug 16, 2024
3 checks passed
@toddeTV toddeTV deleted the feat/3d-node-click-poc branch August 16, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fehnomenal fehnomenal fehnomenal approved these changes

Assignees

@toddeTV toddeTV

Labels
p2-nice-to-have
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add click events to scene
2 participants
@toddeTV @fehnomenal
0