Conversation
2d3516e to
f041c93
Compare
Codecov Report
@@ Coverage Diff @@
## master #811 +/- ##
=======================================
Coverage 75.27% 75.27%
=======================================
Files 18 18
Lines 1436 1436
Branches 336 337 +1
=======================================
Hits 1081 1081
Misses 267 267
Partials 88 88
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
010ebe0 to
1efd8b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason why is I have upcoming changes and refactorings (like #805) that are noops, and we should at least stay with the earlier broken behavior (the broken behavior we know) while we investigate a better way to do v1.13.1. Me and @nvasilas will release an improved solution