E528 don't require shell_command by ThiefMaster · Pull Request #76 · tmux-python/tmuxp · GitHub
[go: up one dir, main page]
Skip to content

don't require shell_command#76

Merged
tony merged 1 commit intotmux-python:masterfrom
ThiefMaster:shell-command-optional
Apr 1, 2014
Merged

don't require shell_command#76
tony merged 1 commit intotmux-python:masterfrom
ThiefMaster:shell-command-optional

Conversation

@ThiefMaster
Copy link
Contributor
@ThiefMaster ThiefMaster commented Apr 1, 2014

Right now this fails:

    panes:
      - focus: true

while this works:

    panes:
      - focus: true
        shell_command:

or this:

    panes:
      -

It would be nice if shell_command defaulted to empty even if other keys were present for the pane.

@tony
Copy link
Member
tony commented Mar 31, 2014

@ThiefMaster: thanks for the report!

So http://tmuxp.readthedocs.org/en/latest/examples.html#blank-panes do not work focus: true?

If I did

ession_name: Blank pane test
windows:
  # Emptiness will simply open a blank pane, if no shell_command_before.
  # All these are equivalent
  - window_name: Blank pane test
    panes:
    -
    - pane
    - blank
      focus: true

that wouldn't work?

@ThiefMaster
Copy link
Contributor Author
ThiefMaster commented Apr 1, 2014 
    - blank
      focus: true

That's invalid YAML - a plain - blank works because that way you get a string value. But with the focus: true below you get an object so blank is a syntax error because there's no : value afterwards.

tony added a commit that referenced this pull request Apr 1, 2014
@tony
Merge pull request #76 from ThiefMaster/shell-command-optional
0c38e58 
don't require shell_command
@tony tony merged commit 0c38e58 into tmux-python:master Apr 1, 2014
tony added a commit that referenced this pull request Apr 1, 2014
@tony
Version 0.1.9, changes by @ThiefMaster #73, #76, #77.
0b880b7
@ThiefMaster ThiefMaster deleted the shell-command-optional branch April 2, 2014 00:24
@ThiefMaster ThiefMaster restored the shell-command-optional branch April 2, 2014 09:54
tony added a commit that referenced this pull request Apr 2, 2014
@tony
Merge remote-tracking branch 'ThiefMaster/shell-command-optional' #76
3a98705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ThiefMaster @tony
0