8000 Allow overwrite on freeze by betoSolares · Pull Request #618 · tmux-python/tmuxp · GitHub
[go: up one dir, main page]
Skip to content

Allow overwrite on freeze#618

Merged
tony merged 2 commits intotmux-python:masterfrom
betoSolares:freeze-overwrite
Oct 12, 2020
Merged

Allow overwrite on freeze#618
tony merged 2 commits intotmux-python:masterfrom
betoSolares:freeze-overwrite

Conversation

@betoSolares
Copy link
Contributor
@betoSolares betoSolares commented Jul 21, 2020

As mentioned in #64 and #537 it would be nice to have an option to overwrite the config file.

This will give the freeze command a new option to overwrite the configuration file.

tmuxp freeze --force <session_name>

@codecov
Copy link
codecov bot commented Jul 21, 2020 •
edited
Loading

Codecov Report

Merging #618 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
+ Coverage   77.08%   77.10%   +0.02%     
==========================================
  Files           6        6              
  Lines         829      830       +1     
  Branches      238      238              
==========================================
+ Hits          639      640       +1     
  Misses        131      131              
  Partials       59       59
Impacted Files Coverage Δ
tmuxp/cli.py 66.09% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdb2154...551ed77. Read the comment docs.

@tony
Copy link
Member
tony commented Jul 26, 2020

@betoSolares Thank you!

Can you add a test for this possibly?

@betoSolares
Copy link
Contributor Author
betoSolares commented Jul 29, 2020

Yeah, no problem.

@aRkedos aRkedos mentioned this pull request Aug 2, 2020
Merged
@tony
Copy link
Member
tony commented Aug 16, 2020

@betoSolares Hi there, sorry about this! Can I get another rebase?

I just merged #623 which moves us to a poetry packaging setup and will runs the PR through GitHub actions.

@betoSolares
Copy link
Contributor Author
betoSolares commented Aug 17, 2020

Rebase done.

@tony
Copy link
Member
tony commented Aug 17, 2020

@betoSolares

Are you sure its rebased against current master? (tests would be running, it seems its not the latest)

@betoSolares
Copy link
Contributor Author
betoSolares commented Aug 18, 2020

@tony I think so. I run:

git remote -v

upstream        https://github.com/tmux-python/tmuxp.git (fetch)
upstream        https://github.com/tmux-python/tmuxp.git (push)

then I did git fetch upstream and git rebase upstream/master and push to my branch.
Is there something I'm missing?

@tony
Copy link
Member
tony commented Aug 18, 2020

@betoSolares

Looks fine now! Thank you!

I will check this out soon!

@tony tony self-requested a review August 18, 2020 15:28
tony
tony approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member
@tony tony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tony tony merged commit 8b8b257 into tmux-python:master Oct 12, 2020
tony added a commit that referenced this pull request Oct 12, 2020
@tony
CHANGES: Update for #618
5b63502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tony tony tony approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@betoSolares @tony
0