-
Notifications
You must be signed in to change notification settings - Fork 236
fix(workspace/builder): Wait for shell prompt before layout and commands #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8000
Mar 8, 2026
Mar 8, 2026
Mar 8, 2026
Mar 8, 2026
Mar 8, 2026
Mar 8, 2026
Mar 8, 2026
2b3eb13
workspace/builder(fix[pane-readiness]): Wait for shell prompt before …
tony 8db8479
docs(CHANGES) Pane-readiness fix for zsh partial-line marker
tony f669002
workspace/builder(fix[logging]): Preserve exception traceback in read…
tony 0139018
tests/workspace/builder(test[pane-readiness]): Add window_shell readi…
tony d3c0c87
workspace/builder(docs[pane-readiness]): Document shell-skip heuristi…
tony 818466e
workspace/builder(fix[doctest]): Increase readiness doctest timeout t…
tony 9debb02
conftest(fix[doctest]): Add rerun markers for tmux-dependent doctests
tony File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some code archaeology on this because I had the same concern about reintroducing old layout/space bugs.
This specific
select_layout()call looks like the redundant one, not the essential one. The builder still appliesselect_layout()per-pane initer_create_panes(), which is the part that actually preservesthe incremental rebalance during pane creation. The call removed here was the second pass in
build(), so it was effectively doubling the layout application after each yielded pane.The historical “no space for new pane” regressions were more closely tied to session geometry than to this duplicate call. In 2022, #793 changed both layout timing and
default-size, and the fallout in #800was mainly from the server starting at
80x24before a client attached. The later fix path was to sizenew_session()correctly (8a59203, then 0777c3b/63ac676d), not to keep a secondselect_layout()here.
I also checked the current regressions:
test_issue_800_default_size_many_windowsstill passes, and this branch addstest_select_layout_not_called_after_yieldspecifically to lock in the intended behavior:call
select_layout()once per pane, not twice. So I don’t think removing this duplicate call should reintroduce the lack-of-space issue.