8000 WIP: Custom frozen dataclasses by tony · Pull Request #586 · tmux-python/libtmux · GitHub
[go: up one dir, main page]
Skip to content

WIP: Custom frozen dataclasses #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

WIP: Custom frozen dataclasses #586

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1a8c32a
pyproject(mypy) Add mypy override for frozen_dataclass method-assign
tony Feb 28, 2025
c94a536
pyproject(ruff) Ignore B010 set-attr-with-constant rule for frozen_da…
tony Feb 28, 2025
a38310f
pyproject(mypy) Add mypy override for `frozen_dataclass_sealable` `me…
tony Feb 28, 2025
bc6666b
pyproject.toml(chore[mypy]): Exclude frozen_dataclass_sealable test f…
tony Mar 1, 2025
269869b
pyproject.toml(chore[lint,types]): Exclude frozen_dataclass_sealable …
tony Mar 1, 2025
eef669b
frozen_dataclass(feat): Add `frozen_dataclass`
tony Feb 28, 2025
9f17f7a
frozen_dataclass_sealable(feat): Add `frozen_dataclass_sealable`
tony Feb 28, 2025
cc86a07
docs(frozen_dataclass) Add to `internals`
tony Feb 28, 2025
0975cfd
docs(frozen_dataclass_sealable) Add to `internals`
tony Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pyproject(mypy) Add mypy override for frozen_dataclass_sealable `me… 
…thod-assign`

why: Fix type checking errors in the custom frozen_dataclass implementation

what:
- Added targeted mypy configuration override to disable method-assign errors
- Only scoped to libtmux._internal.frozen_dataclass module
- Preserves strict type checking across the rest of the codebase

refs: Enables inheritance from mutable to immutable dataclasses
  • Loading branch information
A0D5
@tony
tony committed Apr 6, 2025
commit a38310f7f2f3401fe20f318b68209989058f1628
4 changes: 4 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,10 @@ files = [
module = "libtmux._internal.frozen_dataclass"
disable_error_code = ["method-assign"]

[[tool.mypy.overrides]]
module = "libtmux._internal.frozen_dataclass_sealable"
disable_error_code = ["method-assign"]

[tool.coverage.run]
branch = true
parallel = true
Expand Down
0