8000 py(deps[testing,lint]) Add `typing-extensions` for older python versions by tony · Pull Request #564 · tmux-python/libtmux · GitHub
[go: up one dir, main page]
Skip to content

py(deps[testing,lint]) Add typing-extensions for older python versions#564

Merged
tony merged 2 commits intomasterfrom
typing-extensions-dep
Feb 15, 2025
Merged

py(deps[testing,lint]) Add typing-extensions for older python versions#564
tony merged 2 commits intomasterfrom
typing-extensions-dep

Conversation

@tony
Copy link
Member
@tony tony commented Feb 15, 2025 •
edited by sourcery-ai bot
Loading

In re: #562

Changes

py(deps[testing,lint]) Add typing-extensions for older python versions

Summary by Sourcery

Add typing-extensions to the dev dependencies for Python versions older than 3.11.

@sourcery-ai
Copy link
sourcery-ai bot commented Feb 15, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request adds typing-extensions as a conditional dependency for older Python versions (specifically, versions less than 3.11). This was achieved by adding the dependency to the dev-dependencies, testing, and lint groups in pyproject.toml with a python_version condition. The uv.lock file was also updated to reflect these changes.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added typing-extensions as a conditional dependency for older Python versions.
  • Added typing-extensions to the dev-dependencies group, conditional on python_version < '3.11'.
  • Added typing-extensions to the testing group, conditional on python_version < '3.11'.
  • Added typing-extensions to the lint group, conditional on python_version < '3.11'.
 pyproject.toml
Updated the uv.lock file to reflect the dependency changes.
  • Regenerated the uv.lock file to include the new typing-extensions dependency.
 uv.lock
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@codecov
Copy link
codecov bot commented Feb 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.67%. Comparing base (445066d) to head (9b25993).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #564      +/-   ##
==========================================
+ Coverage   88.59%   88.67%   +0.07%     
==========================================
  Files          36       36              
  Lines        3921     3921              
  Branches      362      362              
==========================================
+ Hits         3474     3477       +3     
+ Misses        309      307       -2     
+ Partials      138      137       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tony tony force-pushed the typing-extensions-dep branch from 7d97878 to 240310a Compare February 15, 2025 12:04
@tony tony marked this pull request as ready for review February 15, 2025 12:06
tony added a commit that referenced this pull request Feb 15, 2025
@tony
docs(CHANGES) Note update from #564
9b25993
@tony tony force-pushed the typing-extensions-dep branch from 9b25993 to 04785aa Compare February 15, 2025 12:10
@tony tony merged commit 3de0cad into master Feb 15, 2025
24 checks passed
@tony tony deleted the typing-extensions-dep branch February 15, 2025 12:10
@tony tony mentioned this pull request Feb 15, 2025
Merged
@lazysegtree lazysegtree mentioned this pull request Feb 17, 2025
Closed
tony added a commit that referenced this pull request Feb 17, 2025
@tony
fix(typings) Move typing-extensions into TypeGuard
cc4e888 
Missed this in #564.
@tony tony mentioned this pull request Feb 17, 2025
Merged
tony added a commit that referenced this pull request Feb 17, 2025
@tony
fix(typings) Move typing-extensions into TypeGuard (#572)
db06c6e 
Resolves #571, follow up to #564.
@tony tony mentioned this pull request Feb 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tony
0