8000 Allow empty window name by ckt114 · Pull Request #444 · tmux-python/libtmux · GitHub
[go: up one dir, main page]
Skip to content

Allow empty window name #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 2, 2022
Merged

Allow empty window name #444

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
130dc36
Allow empty window name.
ckt114 Sep 26, 2022
50164f5
Refactoring.
ckt114 Sep 27, 2022
c825acf
test(empty_window): Assert empty window name passed
tony Oct 2, 2022
7fdb3f3
docs(CHANGES): Note improvement to handling of empty window
tony Oct 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(empty_window): Assert empty window name passed
  • Loading branch information
@tony
tony committed Oct 2, 2022
commit c825acfcd2315db9fa0eb531671b0dc10ae27c8c
14 changes: 13 additions & 1 deletion tests/test_window.py
View file
Open in desktop
Original file line number Diff line number Diff line change
8000 Expand Up @@ -5,7 +5,7 @@
import pytest

from libtmux import exc
from libtmux.common import has_gte_version
from libtmux.common import has_gte_version, has_lt_version
from libtmux.pane import Pane
from libtmux.server import Server
from libtmux.session import Session
Expand Down Expand Up @@ -292,9 +292,21 @@ def test_select_layout_accepts_no_arg(server: Server, session: Session) -> None:
window.select_layout()


@pytest.mark.skipif(
has_lt_version("3.2"), reason="needs filter introduced in tmux >= 3.2"
)
def test_empty_window_name(session: Session) -> None:
session.set_option("automatic-rename", "off")
window = session.new_window(window_name="''", attach=True)

assert window == session.attached_window
assert window.get("window_name") == "''"

cmd = session.cmd(
"list-windows",
"-F",
"#{window_name}",
"-f",
"#{==:#{session_name}," + session.name + "}",
)
assert "''" in cmd.stdout
0