8000 chore: Server.new_session: Create session w/o name by tony · Pull Request #400 · tmux-python/libtmux · GitHub
[go: up one dir, main page]
Skip to content

chore: Server.new_session: Create session w/o name #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tony merged 2 commits into from
Aug 17, 2022
Merged

chore: Server.new_session: Create session w/o name #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50859dc
chore: Server.new_session: Create session w/o name
tony Aug 17, 2022
0dfdc5b
test: Server.new_session w/ no name
tony Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions libtmux/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,15 +535,17 @@ def new_session(
------
:exc:`exc.BadSessionName`
"""
session_check_name(session_name)
assert session_name is not None

if self.has_session(session_name):
if kill_session:
self.cmd("kill-session", "-t%s" % session_name)
logger.info("session %s exists. killed it." % session_name)
else:
raise exc.TmuxSessionExists("Session named %s exists" % session_name)
if session_name is not None:
session_check_name(session_name)

if self.has_session(session_name):
if kill_session:
self.cmd("kill-session", "-t%s" % session_name)
logger.info("session %s exists. killed it." % session_name)
else:
raise exc.TmuxSessionExists(
"Session named %s exists" % session_name
)

logger.debug("creating session %s" % session_name)

Expand Down
8 changes: 8 additions & 0 deletions tests/test_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,14 @@ def test_new_session(server: Server) -> None:
assert server.has_session("test_new_session")


def test_new_session_no_name(server: Server) -> None:
"""Server.new_session works with no name"""
mysession = server.new_session()
session_name = mysession.get("session_name")
assert session_name is not None
assert server.has_session(session_name)


def test_new_session_shell(server: Server) -> None:
"""Server.new_session creates and returns valid session running with
specified command"""
Expand Down
0