Add percent arg to split window#234
Conversation
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
- Coverage 87.02% 86.97% -0.05%
==========================================
Files 16 16
Lines 1526 1528 +2
==========================================
+ Hits 1328 1329 +1
- Misses 198 199 +1
Continue to review full report at Codecov.
|
|
@tony any ideas on how we can test this feature? |
|
@jinankjain Hi there, sorry for the delay, can you rebase? Also, is it possible you could add tests as well? |
|
@jinankjain Hi there, can you rebase this? |
0fd98a5 to
2d0ce9c
Compare
|
@tony Sorry for the late response was kind of busy with other stuff. I have rebased it. |
While spliting window tmux supports '-p' to specify the amount (in percentage) that the newly created pane will occupy with respect to current pane. So let's expose the same functionality by an extra argument percent to split_window function. Signed-off-by: Jinank Jain <jinankj@amazon.de>
2d0ce9c to
703e80b
Compare
It's unlikely a user would ever want to pass 0, but to remain true to what's passed in, allow this.
|
@jinankjain Nicely done. Thanks for your contribution! This will be in the next release! |
|
@jinankjain Released in v0.8.4 |
|
Thanks for merging it. :D |
|
Absolutely, and thank you! |
While spliting window tmux supports '-p' to specify the amount (in
percentage) that the newly created pane will occupy with respect to
current pane. So let's expose the same functionality by an extra
argument percent to split_window function.
Signed-off-by: Jinank Jain jinankj@amazon.de