Conversation
|
Apprently this implements #87 |
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
========================================
+ Coverage 79.97% 80% +0.02%
========================================
Files 8 8
Lines 849 855 +6
========================================
+ Hits 679 684 +5
- Misses 170 171 +1
Continue to review full report at Codecov.
|
|
Is there any chance this can get a test? |
|
Yes was still looking how tests are done in this project will update the PR
when I find some time to work on it.
…On Sat, 24 Feb 2018, 15:55 Tony Narlock, ***@***.***> wrote:
Is there any chance this can get a test?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#103 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAIx_fn9ZKKWDKLtevcJ1UivGzmIajM6ks5tYBS_gaJpZM4SMkz9>
.
|
|
Tests added |
|
Sorry for the late response, I am having issues keeping up with the project. I'm seeking maintainers @ tmux-python/tmuxp#290. If you (or someone you know) may be interested in helping maintain libtmux or tmuxp, feel free to contact me by email or in the tmux-python/tmuxp#290 issue. |
|
When I rebased via Before: After:
|
|
I want to do a release today, ideally. I don't have much time during the weekdays. If this rebase at 654ad41 gets in the way - let me know and I'll force push it out of master and reset things. Though - I'd plan to rebase and merge via GitHub anyway... Also, if I find that GH doesn't give you credit for the commit - I'm going to revert it to make sure you do. This is my mistake. I didn't know the PR "add more commits" feature would react that way (i.e. this feature is how I rebased your PR): |
Make it possible to pass window_name and shell command to server.new_session Make it possible to pass shell command to window.split_window Signed-off-by: Jo De Boeck <deboeck.jo@gmail.com>
|
@tony don't worry about it, I dont mind not getting the credit I rather have it in the release :) |
That's awesome. :) |
Make it possible to pass window_name and shell command to
server.new_session
Make it possible to pass shell command to window.split_window
Signed-off-by: Jo De Boeck deboeck.jo@gmail.com