8000 remove numpy, too aggressive by geohot · Pull Request #3075 · tinygrad/tinygrad · GitHub
[go: up one dir, main page]
Skip to content

remove numpy, too aggressive #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

remove numpy, too aggressive #3075

wants to merge 1 commit into from

Conversation

geohot
Copy link
Collaborator
@geohot geohot commented Jan 10, 2024 •
edited
Loading

If someone wants to break apart this PR, very carefully do each piece of it, and make the tests pass that would be great.

There's some annoyance with the float16 type, 'e' doesn't seem to work.

@github-actions GitHub Actions
Copy link
Contributor

Changes

Name                           Lines    Diff    Tokens/Line    Diff
---------------------------  -------  ------  -------------  ------
tinygrad/tensor.py               680      +5           22.4    -0.1
tinygrad/device.py               269      -5           13.9    -0.1
tinygrad/lazy.py                 234      -6           15.4    +0.1
tinygrad/dtype.py                 75      -3           16.4    -0.1
tinygrad/runtime/ops_cpu.py       44      +5           22.8    -0.4


total lines changes: -4

@geohot geohot marked this pull request as draft January 10, 2024 17:00
@chenyuxyz
Copy link
Collaborator

it looks like float16 support in memoryview is a 3.12 feature python/cpython#90751

@thelonejordan thelonejordan mentioned this pull request Jan 14, 2024
Merged
1 task
@geohot
Copy link
Collaborator Author
geohot commented Jan 15, 2024

This has been (mostly) merged in a series of PRs. I don't see the urgent need to actually remove numpy from the dtype

@geohot geohot closed this Jan 15, 2024
@geohot geohot deleted the remove_numpy_dtype branch September 26, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geohot @chenyuxyz
0