8000 Add ID prop to clipper-upload by eertmanhidde · Pull Request #77 · timtnleeProject/vuejs-clipper · GitHub
[go: up one dir, main page]
Skip to content

Add ID prop to clipper-upload #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add ID prop to clipper-upload #77

wants to merge 1 commit into from

Conversation

eertmanhidde
Copy link

Changes

  • Add an optional ID prop to the clipper-upload component

Reason

This way you can reference the input from labels, in my scenario I want to be able to click on my label that refers to the matching input id.

@timtnleeProject
Copy link
Owner

Hi @eertmanhidde ,
I'm thinking about adding v-bind="$attrs" on clipper-upload
so it can accept all input native props like id, name and accept so we don't need to define these props one by one.

https://vuejs.org/v2/api/#vm-attrs

@eertmanhidde
Copy link
Author

Okay very cool, didn't know about that yet :)
I could try to add that v-bind maybe tonight if I have some time, if you feel like doing it yourself feel free to close this PR 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eertmanhidde @timtnleeProject
0