Add possibility to use previous versions of rest api#333
Merged
timols merged 3 commits intotimols:masterfrom Mar 13, 2019
Merged
Add possibility to use previous versions of rest api#333timols merged 3 commits intotimols:masterfrom
timols merged 3 commits intotimols:masterfrom
Conversation
Owner
|
@yaggg thanks for submitting this! I think this is a good idea, but I wonder if this should instead be set on the instance (in the constructor, still final) instead of being mutable statically? What do you think? That way you could theoretically, if you wanted to, run multiple API versions within the same memory space. |
Contributor
Author
|
@timols Sure, I strongly agree that final instance variable is much better than mutable static variable, do you think I should overload connect method for passing API version? |
Owner
|
Yep, I think that makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.