Fixed: GITHUB-297: The "connectTimeout" parameter is not configurable#298
Merged
timols merged 3 commits intotimols:masterfrom May 3, 2018
shaburov:fix.issue.297.parameter.connectTimeout.is.not.configurable
Merged
Fixed: GITHUB-297: The "connectTimeout" parameter is not configurable#298timols merged 3 commits intotimols:masterfrom shaburov:fix.issue.297.parameter.connectTimeout.is.not.configurable
timols merged 3 commits intotimols:masterfrom
shaburov:fix.issue.297.parameter.connectTimeout.is.not.configurable
Conversation
Refactoring: add getter for host field GitlabAPI && remove unused IOException from the method signature
Contributor
Author
|
@timols ^ |
Owner
|
@shaburov this is great. Any way to add a test for this? |
Contributor
Author
|
@timols |
Contributor
Author
|
@timols or did you mean unit tests and not integration tests? |
Owner
|
Unit tests would be a great start! |
Contributor
Author
|
@timols ^ review please |
Owner
|
@shaburov this is great. Thanks for this contribution! |
Contributor
Author
|
@timols I am glad to help |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring: add getter for host field GitlabAPI &&
remove unused IOException from the method signature