feat: Add missing class properties to core entities#3198
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #3198 +/- ##
=========================================
Coverage 89.85% 89.85%
Complexity 1632 1632
=========================================
Files 57 57
Lines 5017 5017
=========================================
Hits 4508 4508
Misses 509 509 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… MenuItem, Post, Site, Term, and User classes
Co-authored-by: Nicolas Lemoine <nico.lemoine@gmail.com>
Co-authored-by: Nicolas Lemoine <nico.lemoine@gmail.com>
gchtr
approved these changes
Feb 13, 2026
Member
There was a problem hiding this comment.
Nice, thanks for going through all the core entity classes.
Just an obvious hint for anyone reading: We don’t add PHP types yet, because we will handle that in a next major version of Timber, because it might mean introducing breaking changes. The properties together with the comments already provide enough type hinting in IDEs for the moment.
nlemoine
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
Issue
We have quite a few public properties that are missing on our Timber object.
Solution
I've added the missing public properties for Comments, Post, Site,Term, Menu, Menuitem and User
Impact
Better static analysis.
Usage Changes
No
Considerations
Any other Timber class that we need to do the same for?
Testing
no