Implement Background SSTable Compaction Support #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added background SSTable compaction functionality to core.py, including the `start_background_partial_merge` method. - Introduced a monitoring script for background compaction in `samples/compaction_operations.py`. - Added unit tests for background compaction in `tests/test_compaction.py`. - Added functions for compacting SSTables and starting background compaction, along with error handling. - Still pending: Manual Compaction Support. #19
|
Did you solve the segfault issue or is it still apparent? Also were you making sure to use latest master of TidesDB? |
@guycipher Always using the latest till its fresh setup every time i test before pr. Segfault its not solved yet, indeed i should specify that in this craft. But at least |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces support for background SSTable compaction in TidesDB. The following changes have been made:
Background Compaction: A new method,
start_background_partial_merge, was added to handle background compaction. This allows the database to automatically merge SSTables in the background, reducing their count.Monitoring: A new sample script,
compaction_operations.py, was added to demonstrate and monitor the background compaction process. It tracks SSTable sizes, file counts, and the compaction progress.Unit Tests: Tests for background compaction functionality were implemented in
test_compaction.pyto ensure reliability.Current Status
Pending
Additional Note on Stability
While background compaction works correctly across all tested use cases, we've identified a stability issue that requires further investigation:
A segmentation fault occurs at the completion of compaction_operations.py execution
The fault appears to be isolated to the cleanup phase and doesn't affect the compaction operation itself
Issue tracking: After successful compaction operations, the script terminates with
zsh: segmentation fault python compaction_operations.py#19