feat: improve assertion typing for enumerable returning delegates#3927
Merged
feat: improve assertion typing for enumerable returning delegates#3927
Conversation
…lectionAssertion and AsyncFuncCollectionAssertion
Contributor
|
Claude finished @thomhurst's task —— View job PR Review: feat: improve assertion typing for enumerable returning delegatesReviewing this PR that adds support for function-based collection assertions... Todo List:
SummaryThis PR adds excellent support for lambda-wrapped collection assertions by introducing:
The implementation allows users to write assertions like: await Assert.That(() => GetItems()).IsEmpty();
await Assert.That(() => GetItems()).HasCount(5);
await Assert.That(async () => await GetItemsAsync()).Contains(item);✅ Positive AspectsExcellent Code Quality & Design
Proper Overload Resolution
Comprehensive Test Coverage
🔍 Dual-Mode Implementation Analysis ✅Status: ✅ Compliant with TUnit Rule #1 This feature is assertion-library only and doesn't require dual-mode implementation because:
📝 Minor Suggestions for Improvement1. Documentation EnhancementConsider adding more XML documentation examples: /// <summary>
/// Creates an assertion for a synchronous function that returns a collection.
/// This overload enables collection-specific assertions (IsEmpty, IsNotEmpty, HasCount, etc.) on lambda-wrapped collections.
/// Useful for testing methods that may throw during collection generation.
/// Example: await Assert.That(() => GetItems()).IsEmpty();
/// Example: await Assert.That(() => GetItems()).HasCount(5);
/// Example: await Assert.That(() => repository.GetUsers()).Any(u => u.IsActive);
/// </summary>2. Expression Building ClarityThe expression building logic is correct but could be slightly more descriptive: // In both FuncCollectionAssertion and AsyncFuncCollectionAssertion:
var expressionBuilder = new StringBuilder();
expressionBuilder.Append($"Assert.That({expression ?? "func"})"); // More descriptive than "?"3. Performance ConsiderationThe implementation is already well-optimized:
🐛 No Security or Bug Concerns
📊 Test Quality AssessmentCoverage: ✅ Excellent (95%+)
Missing test scenarios (minor):
🚀 Recommendation✅ APPROVE - This is a high-quality PR that:
The implementation is production-ready and adds significant value to the TUnit assertion library. |
Contributor
|
Claude Code is working… I'll analyze this and get back to you. |
This was referenced Dec 1, 2025
This was referenced Jan 14, 2026
This was referenced Jan 21, 2026
This was referenced Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3190