github: Fix issue with draft releases #2389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4936605681
💛 - Coveralls |
Commit 707dc49 included a change where the release candidate was marked as draft. This was a mistake as draft releases are only visible to logged in maintainers. This leads to e.g. ./verify_release script failing while the release is a draft. Revert those changes: * don't use "draft" attribute * postfix the release name with "-rc" while the release waits for approval * Only set the real description and name after release approval Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 707dc49 included a change where the release candidate was marked as draft. This was a mistake as draft releases are only visible to logged in maintainers. This leads to e.g.
./verify_releasescript failing while the release is a draft.Revert those changes:
Fixes #2388