8000 tuf: move INFO logs to DEBUG or WARNING by woodruffw · Pull Request #2243 · theupdateframework/python-tuf · GitHub
[go: up one dir, main page]
Skip to content

tuf: move INFO logs to DEBUG or WARNING #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 27, 2022
Merged

tuf: move INFO logs to DEBUG or WARNING #2243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2876bfd
tuf: move INFO logs to DEBUG or WARNING
woodruffw Dec 20, 2022
408bf9b
api/metadata: blacken
woodruffw Dec 20, 2022
d44fe52
api/metadata: use debug logging
woodruffw Dec 21, 2022
7b89dd9
api/metadata: third time's the charm
woodruffw Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tuf/api/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,9 @@ def verify_delegate(
key.verify_signature(delegated_metadata, signed_serializer)
signing_keys.add(key.keyid)
except exceptions.UnsignedMetadataError:
logger.info("Key %s failed to verify %s", keyid, delegated_role)
logger.debug(
"Key %s failed to verify %s", keyid, delegated_role
)

if len(signing_keys) < role.threshold:
raise exceptions.UnsignedMetadataError(
Expand Down Expand Up @@ -776,7 +778,9 @@ def verify_signature(
SerializationError,
) as e:
# Log unexpected failure, but continue as if there was no signature
logger.info("Key %s failed to verify sig: %s", self.keyid, str(e))
logger.warning(
"Key %s failed to verify sig: %s", self.keyid, str(e)
)
raise exceptions.UnsignedMetadataError(
f"Failed to verify {self.keyid} signature"
) from e
Expand Down
10 changes: 5 additions & 5 deletions tuf/ngclient/_internal/trusted_metadata_set.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def update_root(self, data: bytes) -> Metadata[Root]:
new_root.verify_delegate(Root.type, new_root)

self._trusted_set[Root.type] = new_root
logger.info("Updated root v%d", new_root.signed.version)
logger.debug("Updated root v%d", new_root.signed.version)

return new_root

Expand Down Expand Up @@ -243,7 +243,7 @@ def update_timestamp(self, data: bytes) -> Metadata[Timestamp]:
# protection of new timestamp: expiry is checked in update_snapshot()

self._trusted_set[Timestamp.type] = new_timestamp
logger.info("Updated timestamp v%d", new_timestamp.signed.version)
logger.debug("Updated timestamp v%d", new_timestamp.signed.version)

# timestamp is loaded: raise if it is not valid _final_ timestamp
self._check_final_timestamp()
Expand Down Expand Up @@ -338,7 +338,7 @@ def update_snapshot(
# protection of new snapshot: it is checked when targets is updated

self._trusted_set[Snapshot.type] = new_snapshot
logger.info("Updated snapshot v%d", new_snapshot.signed.version)
logger.debug("Updated snapshot v%d", new_snapshot.signed.version)

# snapshot is loaded, but we raise if it's not valid _final_ snapshot
self._check_final_snapshot()
Expand Down Expand Up @@ -433,7 +433,7 @@ def update_delegated_targets(
raise exceptions.ExpiredMetadataError(f"New {role_name} is expired")

self._trusted_set[role_name] = new_delegate
logger.info("Updated %s v%d", role_name, version)
logger.debug("Updated %s v%d", role_name, version)

return new_delegate

Expand All @@ -453,4 +453,4 @@ def _load_trusted_root(self, data: bytes) -> None:
new_root.verify_delegate(Root.type, new_root)

self._trusted_set[Root.type] = new_root
logger.info("Loaded trusted root v%d", new_root.signed.version)
logger.debug("Loaded trusted root v%d", new_root.signed.version)
2 changes: 1 addition & 1 deletion tuf/ngclient/updater.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ def download_target(
with open(filepath, "wb") as destination_file:
shutil.copyfileobj(target_file, destination_file)

logger.info("Downloaded target %s", targetinfo.path)
logger.debug("Downloaded target %s", targetinfo.path)
return filepath

def _download_metadata(
Expand Down
0