ipc4: helper: Remove hardcoded UUID map for CONFIG_LIBRARY#9516
ipc4: helper: Remove hardcoded UUID map for CONFIG_LIBRARY#9516kv2019i merged 1 commit intothesofproject:mainfrom
Conversation
There was a problem hiding this comment.
These changes worked for IPC4 testbench version too. Getting the controls set to work needs more changes but this is sufficient to load and run all components.
8ef19c8 to
b21fd99
Compare
@singalsu I have updated the patched to also use the already set drv's for the registered components. Could you please check if that helps in your case? |
Yes, everything works now with this version. Thanks a lot! |
|
The cmocka and testbench fails happen also with git main, it's not due to this PR. My own run of those tests with this patch and earlier SOF version worked. |
|
I guess cmocka tests fail due to #9518 ..? Otherwise looks good to go. |
There was a problem hiding this comment.
This is a huge upgrade! Thank you!
|
@ranj063 some conflicts, testbench ipc4 just merged. |
Always append the UUID to the end of the module init IPC data and use that to look up the component driver instead of using the hardcoded UUID map. This will make it easier to support new processing elements with the plugin/testbench. Also, modify the get/set_large_config handlers to use the component driver set in the dev instead of looking it up again. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
b21fd99 to
2658a35
Compare
rebased now @lgirdwood |
Always append the UUID to the end of the module init IPC data and use that to look up the component driver instead of using the hardcoded UUID map. This will make it easier to support new processing elements with the plugin/testbench.