app: shell/winconsole_overlay: disable SOF telemetry#9514
Merged
lgirdwood merged 2 commits intothesofproject:mainfrom Sep 26, 2024
Merged
app: shell/winconsole_overlay: disable SOF telemetry#9514lgirdwood merged 2 commits intothesofproject:mainfrom
lgirdwood merged 2 commits intothesofproject:mainfrom
Conversation
tobonex
approved these changes
Sep 25, 2024
Contributor
There was a problem hiding this comment.
I think we could just disable performance measurements without disabling telemetry, but it's ok.
Collaborator
Author
|
@tobonex If just disable PERFORMANCE_MEASUREMENTS, I get a build error for IO_MEASUREMENTS. If I disable also IO_PERFORMANCE_MEASUREMENTS with: CONFIG_SOF_TELEMETRY_PERFORMANCE_MEASUREMENTS=n ... the DSP boot crashes on boot with debug build (I think due to an assert, I didn't get the log). With a non-debug build, it does boot up and the Zephyr shell works. |
SOF telemetry performance measurement tools use the same window 3 as the DSP winstream log backend and the latter is enabled in the shell overlay. Disable the conflicting feature. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
SOF telemetry performance measurement tools use the same window 3 as the DSP winstream log backend, so the two cannot be enabled at the same time. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
e83adb0 to
206a23b
Compare
Collaborator
Author
|
New version uploaded:
|
lgirdwood
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for #9513