8000 Pipeline2.0: low hanging fruits - move buffers' common params to struct sof_audio_buffer. by marcinszkudlinski · Pull Request #9499 · thesofproject/s 8000 of · GitHub
[go: up one dir, main page]
Skip to content

Pipeline2.0: low hanging fruits - move buffers' common params to struct sof_audio_buffer.#9499

Merged
kv2019i merged 5 commits intothesofproject:mainfrom
marcinszkudlinski:pipeline2_0_004
Sep 27, 2024
Merged

Pipeline2.0: low hanging fruits - move buffers' common params to struct sof_audio_buffer.#9499
kv2019i merged 5 commits intothesofproject:mainfrom
marcinszkudlinski:pipeline2_0_004

Conversation

@marcinszkudlinski
Copy link
Contributor
@marcinszkudlinski marcinszkudlinski commented Sep 20, 2024

This PR moves many of parameters that are common for all buffers to struct sof_audio_buffer

there are 4 left:

	struct comp_dev *source;	/* source component */
	struct comp_dev *sink;		/* sink component */

	/* lists */
	struct list_item source_list;	/* list in comp buffers */
	struct list_item sink_list;	/* list in comp buffers */

and will be moved to sof_audio_buffer in next PR

@marcinszkudlinski
buf: grammar fixes in comments
2d92b98 
a first / the first
procedure / function

Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
@marcinszkudlinski
buf: move is_shared flag to audio_buffer structure
c56abe1 
is_shared is a flag indicating that a buffer is shared
between cores.
This property is common for all types of audio buffers and
should be kept in a base structure

Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
lyakh
lyakh reviewed Sep 23, 2024
View reviewed changes
kv2019i
kv2019i approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator
@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The is/are_hw_params seems rather minor.

8000
@marcinszkudlinski
Copy link
Contributor Author
marcinszkudlinski commented Sep 24, 2024

there's a problem with CI loadable library test, checking

@marcinszkudlinski
buf: move hw_params_configured flag to stream_params structure
7cecc11 
hw_params_configured is a flag indicating that a buffer params has
been already set, and should be kept in the same structure as the
params themselves

this commit moves hw_params_configured to sof_audio_stream_params
and introduces API to handle the flag

Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
@marcinszkudlinski
buf: move walking flag to sof_audio_buffer structure
68d8ea0 
walking flag is not really needed for data buffering,
rather for pipeline iteration procedures, so it should
not be in sof_audio_buffer structure. But before in order
to make possible usage of other buffer types than comp_buffer
before pipeline2.0 is ready, it must be kept there.

Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
@marcinszkudlinski
buf: move chmap to stream_params structure
dd4c512 
chmap is a parameter common for all types of buffers, should be
accessible through sink/src api, so it needs to be kept in
sof_audio_stream_params

an API inroduced for accessing the parameter

Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
@marcinszkudlinski
Copy link
Contributor Author
marcinszkudlinski commented Sep 27, 2024

internal CI that was failing is green, jenkins did not start. Lately there was couple of similar problems in several PRs

BlobNotFoundThe specified blob does not exist. RequestId:edb2f1ad-201e-0086-7fa7-105dd6000000 Time:2024-09-27T06:33:40.4681943Z

@kv2019i
Copy link
Collaborator
kv2019i commented Sep 27, 2024

SOFCI TEST

@kv2019i kv2019i merged commit 64cb133 into thesofproject:main Sep 27, 2024
@marcinszkudlinski marcinszkudlinski deleted the pipeline2_0_004 branch September 27, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyakh lyakh lyakh left review comments

@lgirdwood lgirdwood lgirdwood approved these changes

@kv2019i kv2019i kv2019i approved these changes

@bardliao bardliao Awaiting requested review from bardliao bardliao is a code owner

@pblaszko pblaszko Awaiting requested review from pblaszko pblaszko is a code owner

@tlissows tlissows Awaiting requested review from tlissows tlissows is a code owner

@fkwasowi fkwasowi Awaiting requested review from fkwasowi fkwasowi is a code owner

@RanderWang RanderWang Awaiting requested review from RanderWang RanderWang is a code owner

@abonislawski abonislawski Awaiting requested review from abonislawski abonislawski is a code owner

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

+1 more reviewer

@cujomalainey cujomalainey cujomalainey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pipeline2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marcinszkudlinski @kv2019i @lyakh @cujomalainey @lgirdwood
0