Change the soc from ace30_ptl to ace30 (includes Zephyr west.yml update)#9475
Conversation
6c597ce to
3849f37
Compare
3849f37 to
4815c15
Compare
4815c15 to
4c68bb2
Compare
94af31f to
d2af4f0
Compare
There was a problem hiding this comment.
These changes require modifications on the Zephyr side. You must update the Zephyr version in the west along with this commit in order to build the FW and pass the CI.
Never mind, I see that you've already done it. |
I'm checking what's happening on zephyr as currently my ticket has failed twister tests and I don't know if it will be reverted. |
app/sample.yaml
Outdated
| - intel_adsp/ace15_mtpm | ||
| - intel_adsp/ace20_lnl | ||
| - intel_adsp/ace30 | ||
| - intel_adsp/ace30_ptl |
There was a problem hiding this comment.
please also rename the simulator instances in the sample.yaml file.
app/sample.yaml
Outdated
| - intel_adsp/ace20_lnl | ||
| - intel_adsp/ace30 | ||
| - intel_adsp/ace30_ptl | ||
| - intel_adsp/ace30_ptl_sim |
|
@gbernatxintel Please also rebase. A few platform files have been removed in SOF main and are no longer needed at all. This simplifies adding new platforms, but will require some changes to this PR before can be submitted. |
Renamed soc from ace30_ptl to ace30. We were previously using the wrong soc name. The correct name is ace30. There is only one ptl platform, but there can be several ace30 platforms. Signed-off-by: Grzegorz Bernat <grzegorzx.bernat@intel.com>
d2af4f0 to
ad068df
Compare
Ok, I rebased my changes |
There was a problem hiding this comment.
Would be good to mention Zephyr version is updated also in the commit. Not a blocker, but in case you need to update this for other reasons.
| elseif(CONFIG_SOC_INTEL_ACE20_LNL) | ||
| set(PLATFORM "lunarlake") | ||
| elseif(CONFIG_SOC_INTEL_ACE30_PTL) | ||
| set(PLATFORM "pantherlake") |
There was a problem hiding this comment.
No need to change, but we do have prior examples of using the first product/variant name to name new platforms. E.g. all Intel "cAVS2.5" are referred to as "tigerlake" (e..g src/platform/tigerlake in SOF). This is not fully correct, but there is a system to it, using the name of the first submitted veriant.
In retrospect, this could have been used here as well and avoid the ace30_ptl->ace30 rename effort, but alas, that's now done, so let's just complete this.
FYI @nashif @abonislawski @marcinszkudlinski
|
Build Infra needs updated. PRs wont be blocked in short term, any breakage can be addressed after build fix. |
Renamed soc from ace30_ptl to ace30.
We were previously using the wrong soc name.
The correct name is ace30.
There is only one ptl platform, but there can be several ace30 platforms.
Dependencies:
zephyrproject-rtos/zephyr#78474