tools: plugin: Fix TODOs in README#10005
Merged
kv2019i merged 1 commit intothesofproject:mainfrom May 15, 2025
Merged
Conversation
Replace completed ones with new items. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the TODO items in the README to replace completed items with new actionable tasks for single pipeline end-to-end audio support.
- Removed outdated items with T-shirt sizing
- Introduced new tasks focusing on using hw_params, supporting additional audio bit depths, and addressing alsamixer kcontrol duplication
Comments suppressed due to low confidence (2)
tools/plugin/README.md:159
- [nitpick] Consider clarifying which hw_params implementation or configuration adjustments are intended; a brief reference or additional context might help readers understand the expected change.
Use hw_params instead of hardcoded config
tools/plugin/README.md:161
- Please verify that the removal of duplicated kcontrols does not inadvertently affect the alsamixer's behavior or UI state, and consider adding a note on the intended resolution if this task is more complex.
Remove duplication of kcontrols when alsamixer is opened/closed repeatedly
dbaluta
approved these changes
May 13, 2025
kv2019i
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace completed ones with new items.