ci: Add pre-commit #12
Conversation
|
@matthewfeickert and @henryiii, mind giving this a review? |
There was a problem hiding this comment.
@j-s-ashley Looks good, but I would rebase and squash the pre-commit.ci changes that were pushed back with your previous commit so that all the changes are in 1 commit.
|
I should also say that in a follow up PR to this PR, to keep c.f. matplotlib/matplotlib#22809 for an example of this. |
* Add pre-commit config * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
That's why I'd personally leave these in two commits, and rebase and merge. The manual changes (adding the .pre-commit file) in one, and one fully automated change that can be added to the Also makes it easier if you ever need to rebase, you can just drop the fully automated comment and rerun pre-commit to remake it. |
There was a problem hiding this comment.
That's why I'd personally leave these in two commits, and rebase and merge.
That's what I was trying to communicate, but I see how my
all the changes are in 1 commit.
could be confusing (I meant all the pre-commit applied changes).
Anyway, this LGTM so @rikab this is ready for your review.
|
@rikab Ping on merging this. As this is something that both @henryiii and I strongly advocate for, we'll have @j-s-ashley merge this in by the end of the day if you don't have any comments. If you later do have any, we can revisit this. |
Adds pre-commit to resolve #11.