fix: no connect to docker on startup #831
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could we get rid of all UPPER_CASE variables? Having to delay import to set a config for a lib is just not applicable on how people test things in python. I suggest merging the PR and I hope I find time to proprose another PR that handles config runtime changable properly. |
CarliJoy
suggested changes
Jun 17, 2025
| ryuk_privileged: bool = RYUK_PRIVILEGED | ||
| ryuk_disabled: bool = RYUK_DISABLED | ||
| ryuk_docker_socket: str = RYUK_DOCKER_SOCKET | ||
| # ryuk_docker_socket: str = RYUK_DOCKER_SOCKET |
Contributor
There was a problem hiding this comment.
Suggested change
| # ryuk_docker_socket: str = RYUK_DOCKER_SOCKET | |
| _ryuk_docker_socket: str = "" |
Comment on lines
+134
to
+136
| @property | ||
| def ryuk_docker_socket(self) -> str: | ||
| return get_docker_socket() |
Contributor
There was a problem hiding this comment.
Suggested change
| @property | |
| def ryuk_docker_socket(self) -> str: | |
| return get_docker_socket() | |
| @property | |
| def ryuk_docker_socket(self) -> str: | |
| if not self._ryuk_docker_socket: | |
| self.ryuk_docker_socket = get_docker_socket() | |
| return self._ryuk_docker_socket | |
| @ryuk_docker_socket.setter | |
| def ryuk_docker_socket(self, value: str) -> None: | |
| self._ryuk_docker_socket = value |
Cache the result but make it changeable
Contributor
|
See #833 |
Member
Author
|
closing in favor of #833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #830