8000 new api by SergeyPirogov · Pull Request #5 · testcontainers/testcontainers-python · GitHub
[go: up one dir, main page]
Skip to content

new api #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SergeyPirogov merged 20 commits into from
Mar 28, 2017
Merged

new api #5

SergeyPirogov merged 20 commits into from
Mar 28, 2017

Conversation

@SergeyPirogov
Copy link
Contributor
@SergeyPirogov SergeyPirogov commented Mar 28, 2017

No description provided.

sepi and others added 19 commits March 22, 2017 14:14
GenericContainer added
747499e
DockerContainer additional methods
a9ff782
mysql environ variables added
7eaf522
mysql environ variables added
3a34969
@gospodinkot
test for env variables added
3d61ad0
@gospodinkot
test for env variables fixed
b40eb94
@gospodinkot
postgres fix
0c1b287
postgres get_connection_url fix
1d31a52
release process description changed
4e82ef2
with_name added to docker container class
b2cc817
@SergeyPirogov
Merge branch 'master' into develop
e274697
with_mount_volumes added to docker container
c5294e8
Merge remote-tracking branch 'origin/develop' into develop
eb9ab36 
# Conflicts:
#	testcontainers/core/container.py
test fix for port bindings
8344e78
with_exposed_ports added
a87d85d
_configure deleted from DockerContainer class
147ad5b
@gospodinkot
tests fix
e46f36e
test fix for custom image
0352b76
@SergeyPirogov
Merge branch 'master' into develop
ad59d61
@pep8speaks
Copy link
pep8speaks commented Mar 28, 2017

Hello @SergeyPirogov! Thanks for submitting the PR.

Line 25:80: E501 line too long (85 > 79 characters)
Line 36:80: E501 line too long (87 > 79 characters)
Line 39:80: E501 line too long (81 > 79 characters)
Line 41:80: E501 line too long (80 > 79 characters)
Line 44:80: E501 line too long (80 > 79 characters)
Line 46:80: E501 line too long (89 > 79 characters)
Line 75:80: E501 line too long (100 > 79 characters)

Line 35:80: E501 line too long (81 > 79 characters)

Line 9:21: W292 no newline at end of file

Line 45:80: E501 line too long (96 > 79 characters)
Line 46:80: E501 line too long (97 > 79 characters)

Line 25:80: E501 line too long (82 > 79 characters)

@codecov
Copy link
codecov bot commented Mar 28, 2017 •
edited
Loading

Codecov Report

Merging #5 into master will decrease coverage by 0.13%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage   86.04%   85.91%   -0.14%     
==========================================
  Files          12       12              
  Lines         215      213       -2     
  Branches        8        8              
==========================================
- Hits          185      183       -2     
  Misses         26       26              
  Partials        4        4
Impacted Files Coverage Δ
testcontainers/core/docker_client.py 100% <ø> (ø) ⬆️
testcontainers/oracle.py 40% <0%> (ø) ⬆️
testcontainers/core/generic.py 100% <100%> (ø) ⬆️
testcontainers/postgres.py 100% <100%> (ø) ⬆️
testcontainers/mysql.py 100% <100%> (ø) ⬆️
testcontainers/__init__.py 100% <100%> (ø) ⬆️
testcontainers/selenium.py 88.88% <66.66%> (ø) ⬆️
testcontainers/core/container.py 81.25% <81.25%> (ø) ⬆️
testcontainers/core/waiting_utils.py 89.47% <0%> (-1.01%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19201c8...42d3e41. Read the comment docs.

@SergeyPirogov SergeyPirogov merged commit dae61ea into master Mar 28, 2017
@SergeyPirogov SergeyPirogov deleted the develop branch October 13, 2017 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SergeyPirogov @pep8speaks @gospodinkot
0