8000 Use binary psycopg2 packages by walles · Pull Request #40 · testcontainers/testcontainers-python · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@walles
Copy link
Contributor
@walles walles commented Sep 27, 2019

Quoting the psycopg2-binary web page:

The binary package is a practical choice for development and testing but in production it is advised to use the package built from sources.

For me right now, not having had to build psycopg2 from source while testing would have made my life easier.

@codecov-io
Copy link
codecov-io commented Sep 27, 2019

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   77.64%   77.64%           
=======================================
  Files          17       17           
  Lines         331      331           
  Branches       21       21           
=======================================
  Hits          257      257           
  Misses         59       59           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bf5687...a84408d. Read the comment docs.

Quoting its web page:
> The binary package is a practical choice for development and testing but in production it is advised to use the package built from sources.

For me right now, not having had to build psycopg2 from source would have made my life easier.
@SergeyPirogov SergeyPirogov merged commit 53a905b into testcontainers:master Sep 27, 2019
@walles walles deleted the walles/psycopg2-bin branch October 14, 2019 11:17
@walles
Copy link
Contributor Author
walles commented Oct 16, 2019

@SergeyPirogov would it be possible for you to make a new release with this change in it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0