8000 fix: pin PyYAML to 5.3.1 for Python versions >= 3.10 by mloesch · Pull Request #376 · testcontainers/testcontainers-python · GitHub
[go: up one dir, main page]
Skip to content

fix: pin PyYAML to 5.3.1 for Python versions >= 3.10 #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mloesch wants to merge 1 commit into from
Closed

fix: pin PyYAML to 5.3.1 for Python versions >= 3.10 #376

mloesch wants to merge 1 commit into from

Conversation

@mloesch
Copy link
Contributor
@mloesch mloesch commented Jul 31, 2023 •
edited
Loading

PR builds are currently failing with PyYAML 5.4.1 due to a Cython incompatibility.

E.g. https://github.com/testcontainers/testcontainers-python/actions/runs/5570814818/job/15393831115?pr=371

Upgrading PyYAML to 6.X is not an option because docker-compose V1 is incompatible and won't receive any updates due to EOL (see docker/compose#9114).

This should be the temporary fix until #358 is implemented.

References:

@mloesch mloesch mentioned this pull request Nov 10, 2023
Merged
@mloesch
Copy link
Contributor Author
mloesch commented Nov 23, 2023

Superseded by #394

@mloesch mloesch closed this Nov 23, 2023
@mloesch mloesch deleted the downgrade-pyyaml branch November 23, 2023 16:26
@alexanderankin alexanderankin mentioned this pull request Nov 24, 2023
Merged
@kiview
Copy link
Member
kiview commented Nov 24, 2023

Thank you for providing this PR and sorry for not reviewing and considering it before implementing #394. Please see this comment explaining our rationale to do so.

@mloesch
Copy link
Contributor Author
mloesch commented Nov 27, 2023

@kiview thanks for the explanation! No worries, my intention here was just to unblock the failing build. I agree that abandoning the deprecated V1 compose is the better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

👀 requires attention

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mloesch @kiview
0