Add support for IBM Db2 #321
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for containers created from the
ibmcom/db2image.Notes
ibm_db_saused for Db2 does not yet support SQLAlchemy 2.0 (the devs are currently working on it), so this PR won't be able to go in until then, but thought I'd still get the review meanwhile. Alternatively, can I specifysqlalchemy<2in thesetup.pythat I created?Checks
__init__.py) and corresponding tests.-e file:[feature name]torequirements.inand runmake requirements. This command will find any new requirements and generate lock files to ensure reproducible builds (see the pip-tools documentation for details). Then runpip install -r requirements/[your python version].txtto install the new requirements.README.rstand add it to the table of contents (toctreedirective) in the top-levelREADME.rst.[feature name]to the list of components in the GitHub Action workflow in.github/workflows/main.ymlto run tests, build, and publish your package when pushed to themasterbranch.master(or mergemasterinto your development branch).