8000 [fix/oracle]: service name is XE, not xe. by pmpetit · Pull Request #214 · testcontainers/testcontainers-python · GitHub
[go: up one dir, main page]
Skip to content

[fix/oracle]: service name is XE, not xe. #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pmpetit wants to merge 1 commit into from
Closed

[fix/oracle]: service name is XE, not xe. #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testcontainers/oracle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def __init__(self, image="wnameless/oracle-xe-11g-r2:latest", **kwargs):
def get_connection_url(self):
return super()._create_connection_url(
dialect="oracle", username="system", password="oracle", port=self.container_port,
db_name="xe"
db_name="XE"
)

def _configure(self):
Expand Down
0