8000 Allow Docker Client Configuration by timbmg · Pull Request #210 · testcontainers/testcontainers-python · GitHub
[go: up one dir, main page]
Skip to content

Allow Docker Client Configuration #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tillahoffmann merged 8 commits into from
May 9, 2022
Merged

Allow Docker Client Configuration #210

tillahoffmann merged 8 commits into from
May 9, 2022

Conversation

@timbmg
Copy link
Contributor
@timbmg timbmg commented Apr 28, 2022

Allows to control parameters passed to DockerClient.from_env to configure the docker client. Allowed parameters can be found in the docker-py docs.

Fixes #180

@tillahoffmann
Copy link
Contributor
tillahoffmann commented May 6, 2022

Nice, are there sensible tests we can add to make sure this works as expected?

@codecov-commenter
Copy link
codecov-commenter commented May 7, 2022

Codecov Report

Merging #210 (737f214) into master (85bc030) will increase coverage by 0.14%.
The diff coverage is 95.65%.

❗ Current head 737f214 differs from pull request most recent head b38e02e. Consider uploading reports for the commit b38e02e to get more accurate results

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   85.52%   85.67%   +0.14%     
==========================================
  Files          25       25              
  Lines         670      670              
  Branches       64       60       -4     
==========================================
+ Hits          573      574       +1     
  Misses         76       76              
+ Partials       21       20       -1
Impacted Files Coverage Δ
testcontainers/redis.py 85.71% <ø> (ø)
testcontainers/oracle.py 55.55% <50.00%> (ø)
testcontainers/core/container.py 77.65% <100.00%> (+1.06%) ⬆️
testcontainers/core/docker_client.py 51.16% <100.00%> (ø)
testcontainers/elasticsearch.py 92.59% <100.00%> (ø)
testcontainers/google/pubsub.py 95.45% <100.00%> (ø)
testcontainers/kafka.py 100.00% <100.00%> (ø)
testcontainers/localstack.py 94.44% <100.00%> (ø)
testcontainers/mongodb.py 100.00% <100.00%> (ø)
testcontainers/mssql.py 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85bc030...b38e02e. Read the comment docs.

@timbmg
Copy link
Contributor Author
timbmg commented May 7, 2022

Nice, are there sensible tests we can add to make sure this works as expected?

I have added tests that make sure that the .from_env is called properly. But, these are very high level. The functionality is implemented in the docker package itself, so not quite sure what better tests we could do. Any suggestions welcome though:)

tillahoffmann
tillahoffmann reviewed May 9, 2022
View reviewed changes
Copy link
Contributor
@tillahoffmann tillahoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, just one small suggestion.

timbmg and others added 2 commits May 9, 2022 15:55
@timbmg @tillahoffmann
improve default condition
88a46d2 
Co-authored-by: Till Hoffmann <tillahoffmann@gmail.com>
@timbmg
Merge branch 'master' into docker-client-config
a800dfc
@tillahoffmann tillahoffmann merged commit df0c28a into testcontainers:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tillahoffmann tillahoffmann tillahoffmann left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose docker.from_env() parameters

3 participants

@timbmg @tillahoffmann @codecov-commenter
0