E526 Fix deprecation warning message for `ElasticsearchContainer` by yakimka · Pull Request #171 · testcontainers/testcontainers-python · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@yakimka
Copy link
Contributor
@yakimka yakimka commented Jan 10, 2022

When I use ElasticsearchContainer class I get a "DeprecatedWarning: ElasticSearchContainer is deprecated" message which is wrong. This PR fixes this.

@yakimka yakimka requested a review from tillahoffmann March 24, 2022 01:17
@yakimka
Copy link
Contributor Author
yakimka commented Mar 26, 2022

@tillahoffmann can you review this, please?

@codecov-commenter
Copy link
codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #171 (8a3976c) into master (2aefee2) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
+ Coverage   85.49%   85.51%   +0.02%     
==========================================
  Files          25       25              
  Lines         655      656       +1     
  Branches       61       61              
==========================================
+ Hits          560      561       +1     
  Misses         75       75              
  Partials       20       20              
Impacted Files Coverage Δ
testcontainers/elasticsearch.py 92.59% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aefee2...8a3976c. Read the comment docs.

@tillahoffmann tillahoffmann merged commit 3bd7ae9 into testcontainers:master Apr 3, 2022
@yakimka yakimka deleted the elastic_depr_message branch April 3, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0