8000 Build option for DockerCompose by aloosley · Pull Request #168 · testcontainers/testcontainers-python · GitHub
[go: up one dir, main page]
Skip to content

Build option for DockerCompose #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yakimka merged 12 commits into from
Apr 2, 2022
Merged

Build option for DockerCompose #168

yakimka merged 12 commits into from
Apr 2, 2022

Conversation

@aloosley
Copy link
Contributor
@aloosley aloosley commented Jan 7, 2022

There are some usecases where it is useful to force building to occur when using docker-compose (the equivalent to docker-compose up --build).

In this PR, a boolean parameter is added to allow for this, similar to the pull boolean parameter that already exists to force image pulling.

@KerstenBreuer KerstenBreuer mentioned this pull request Jan 12, 2022
Closed
@yakimka
Copy link
Contributor
yakimka commented Apr 1, 2022

@aloosley, hello. Can you update this PR?

tillahoffmann
8000
tillahoffmann reviewed Apr 1, 2022
View reviewed changes
@aloosley
Copy link
Contributor Author
aloosley commented Apr 1, 2022

Hi both, thanks for checking in on this PR! First glance, the needed change looks small. I'll do this (and try to write a better test) in the next day when I get to a computer.

@codecov-commenter
Copy link
codecov-commenter commented Apr 1, 2022 •
edited
Loading

Codecov Report

Merging #168 (ff507e1) into master (9100aaf) will increase coverage by 0.00%.
The diff coverage is 90.00%.

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   85.07%   85.08%           
=======================================
  Files          24       24           
  Lines         630      637    +7     
  Branches       59       61    +2     
=======================================
+ Hits          536      542    +6     
  Misses         75       75           
- Partials       19       20    +1
Impacted Files Coverage Δ
testcontainers/compose.py 98.24% <90.00%> (-1.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9100aaf...ff507e1. Read the comment docs.

@aloosley
Copy link
Contributor Author
aloosley commented Apr 2, 2022

Alright @yakimka, I cleaned up the PR a bit. Testing build=True would have been a bit complicated, so rather than add something complicated to this PR, I opted for the simple test option of simply making sure the arg --build actually gets used when docker-compose is called. I hope this solution is ok.

yakimka
yakimka suggested changes Apr 2, 2022
View reviewed changes
yakimka
yakimka reviewed Apr 2, 2022
View reviewed changes
yakimka
yakimka reviewed Apr 2, 2022
View reviewed changes
@aloosley
Copy link
Contributor Author
aloosley commented Apr 2, 2022

🥳 Thanks @yakimka, any other steps needed here?

@yakimka
Copy link
Contributor
yakimka commented Apr 2, 2022

@aloosley thank you =)

@yakimka yakimka merged commit 1f0ca14 into testcontainers:master Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tillahoffmann tillahoffmann tillahoffmann left review comments

@yakimka yakimka yakimka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

👀 requires attention

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aloosley @yakimka @codecov-commenter @tillahoffmann
0