[Fix/144] wait_for_logs working for DockerCompose #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added logs for container * updated docker compose for tests * added test for container logs
Contributor
|
@singerjess, can you update this PR? I want to merge it |
Contributor
Author
Just Did! But I need someone to authorize the pipeline build |
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
- Coverage 85.28% 85.10% -0.18%
==========================================
Files 24 24
Lines 632 638 +6
Branches 59 60 +1
==========================================
+ Hits 539 543 +4
- Misses 75 76 +1
- Partials 18 19 +1
Continue to review full report at Codecov.
|
yakimka
approved these changes
Mar 27, 2022
Contributor
|
@singerjess thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality of "wait_for_logs" for Compose containers (see this issue).
Fixed by adding method to get logs in the Generic container, similar to the one on the Compose container, then using it in the wait_for_logs method instead of going through the private attribute "_container".