fix: use stack-ids and tags to remove fragile relative paths #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of fixes to improve the example:
tm_dynamic
because there's no need to be looping over a list with a single entry, it only makes the example harder to follow_
, since this is a standard practice we use to ensure it's easy to distinguish between generated and non-generated terraformbefore
in VPC to be anafter
in EC2. Though they're logically equal, it's more normal to want to see the stack dependencies in the stack itself.after
and replaced them with a stack-id and tags respectively (after
doesn't support stack ids yet). Relative paths are fragile and make it much more difficult to reorganise code. I think it's best if we try to make this repo follow best practices even for simple examples.