[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use stack-ids and tags to remove fragile relative paths #15

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

kkmlr
Copy link
Contributor
@kkmlr kkmlr commented Jan 5, 2024

A number of fixes to improve the example:

  • We should always aim for reduction in code duplication using globals wherever possible
  • I've removed the tm_dynamic because there's no need to be looping over a list with a single entry, it only makes the example harder to follow
  • I've prefixed all generated files with _, since this is a standard practice we use to ensure it's easy to distinguish between generated and non-generated terraform
  • I've changed the before in VPC to be an after in EC2. Though they're logically equal, it's more normal to want to see the stack dependencies in the stack itself.
  • I've removed the relative paths in the remote state and the after and replaced them with a stack-id and tags respectively (after doesn't support stack ids yet). Relative paths are fragile and make it much more difficult to reorganise code. I think it's best if we try to make this repo follow best practices even for simple examples.

@soerenmartius soerenmartius marked this pull request as ready for review January 5, 2024 17:47
@soerenmartius soerenmartius requested review from a team as code owners January 5, 2024 17:47
@vtimd vtimd merged commit a632d5f into tim-example-add-1 Jan 5, 2024
@vtimd vtimd deleted the kkmlr/no-relative-path branch January 5, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants