Adding 3rd example to repo #12
Conversation
| "dependencies" = [ | ||
| "stacks/vpc", | ||
| ] | ||
| } |
There was a problem hiding this comment.
We should always add a "newline at the end of each file", hence the stop sign here.
Here's how to do that with vscode: https://stackoverflow.com/questions/44704968/visual-studio-code-insert-newline-at-the-end-of-files
And that's why: https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline
|
@vtimd just tried the code locally, it unfortunately doesn't work (try run Keep in mind that the example we defined in last weeks session was never tested and was meant as an example for you how the final implementation could look like |
|
This PR was just a placeholder for the file links. I didn’t test the code. I’m going to get it fixed in parallel while I write the blog. I just needed the GitHub links for the blog. I knew the code was wrong when I saved it in Code. It was all red 😂 |
Ok understood. In general it's a recommended best practice to open PRs that aren't ready for review yet as draft pull requests as otherwise folks receive a notification that your PR is ready for review |
03-terraform-outputs-across-stacks/stacks/EC2/dependencies.tm.hcl
Outdated
Show resolved
Hide resolved
Co-authored-by: Kyle Knight <106227170+kkmlr@users.noreply.github.com>
Co-authored-by: Kyle Knight <106227170+kkmlr@users.noreply.github.com>
Co-authored-by: Sören Martius <soeren.martius@gmail.com>
03-terraform-outputs-across-stacks/stacks/EC2/dependencies.tm.hcl
Outdated
Show resolved
Hide resolved
Co-authored-by: Kyle Knight <106227170+kkmlr@users.noreply.github.com>
| region = "us-east-1" | ||
| encrypt = true | ||
| } | ||
| } |
There was a problem hiding this comment.
formatting issue (run terramate fmt)
|
Closing. Starting Fresh. |
This pull request will add the 3rd set of example code to the repo for the blog on how to use terraform outputs across stacks.