8000 feat: add example for GKE confidential nodes with GPU by arthurlapertosa · Pull Request #2426 · terraform-google-modules/terraform-google-kubernetes-engine · GitHub
[go: up one dir, main page]
Skip to content

feat: add example for GKE confidential nodes with GPU #2426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add example for GKE confidential nodes with GPU #2426

wants to merge 3 commits into from

Conversation

arthurlapertosa
Copy link
Contributor

No description provided.

@arthurlapertosa arthurlapertosa marked this pull request as ready for review August 28, 2025 03:59
@arthurlapertosa arthurlapertosa requested review from a team, apeabody and ericyz as code owners August 28, 2025 03:59
@arthurlapertosa
Copy link
Contributor Author
arthurlapertosa commented Aug 28, 2025 •
edited
Loading

@apeabody could you please run the build for this PR?

@apeabody
Copy link
Collaborator

/gcbrun

@arthurlapertosa
Copy link
Contributor Author

@apeabody I don't have access to the GCP cloud build project. Could you please send me the error?

@apeabody
Copy link
Collaborator

@apeabody I don't have access to the GCP cloud build project. Could you please send me the error?

Error: Reference to undeclared input variable

  on ../../modules/beta-autopilot-private-cluster/cluster.tf line 72, in resource "google_container_cluster" "primary":
  72:       confidential_instance_type = lookup(var.node_pools[0], "confidential_instance_type", null)

An input variable with the name "node_pools" has not been declared. This
variable can be declared with a variable "node_pools" {} block.}

@arthurlapertosa
Copy link
Contributor Author
8000

@apeabody could you please re-run the build?

@apeabody
Copy link
Collaborator

/gcbrun

@arthurlapertosa
Copy link
Contributor Author

@apeabody I think the build wasn't properly triggered, could you please take a look?

@apeabody
Copy link
Collaborator
apeabody commented Sep 2, 2025

/gcbrun

@apeabody
Copy link
Collaborator
apeabody commented Sep 2, 2025

@apeabody I think the build wasn't properly triggered, could you please take a look?

Might have been too quick after the merge, it's running now.

apeabody
apeabody requested changes Sep 2, 2025
View reviewed changes
Copy link
Collaborator
@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arthurlapertosa!

autogen/main/cluster.tf.tmpl
content {
enabled = confidential_nodes.value.enabled
{% if autopilot_cluster != true %}
confidential_instance_type = lookup(var.node_pools[0], "confidential_instance_type", null)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document any new node_pool parameters in https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/main/autogen/main/README.md?plain=1#L190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apeabody apeabody apeabody requested changes

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arthurlapertosa @apeabody
0