8000 feat: Support for cross region VPC endpoints by mmeidlinger · Pull Request #1161 · terraform-aws-modules/terraform-aws-vpc · GitHub
[go: up one dir, main page]
Skip to content

feat: Support for cross region VPC endpoints #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2025
Merged

feat: Support for cross region VPC endpoints #1161

merged 2 commits into from
Jan 27, 2025

Conversation

mmeidlinger
Copy link
Contributor

Description

Adds cross-region capabilities for VPC endpoints.

Motivation and Context

AWS added cross-region support for VPC Private link in November 2024. Support for that feature was added in the AWS Terraform provider release 5.83.

Breaking Changes

No breaking changes, backwards compatible.

How Has This Been Tested?

Tested and validated both the old syntax (of not providing the service_region as part of var.endpoints as well as with adding it.

@mmeidlinger mmeidlinger changed the title Support for cross region VPC endpoints feat: Support for cross region VPC endpoints Jan 27, 2025
@mmeidlinger mmeidlinger force-pushed the feat/multi-region-endpoints branch from 018fdf9 to 9467b6e Compare January 27, 2025 12:55
@antonbabenko antonbabenko merged commit 7e205ad into terraform-aws-modules:master Jan 27, 2025
18 checks passed
antonbabenko pushed a commit that referenced this pull request Jan 27, 2025
@semantic-release-bot
chore(release): version 5.18.0 [skip ci]
8d6eba2 
## [5.18.0](v5.17.0...v5.18.0) (2025-01-27)

### Features

* Support for cross region VPC endpoints ([#1161](#1161)) ([7e205ad](7e205ad))
@antonbabenko
Copy link
Member

This PR is included in version 5.18.0 🎉

@mmeidlinger
Copy link
Contributor Author
mmeidlinger commented Jan 27, 2025 •
edited
Loading

Thanks, awesome turnaround time @antonbabenko
I think though I missed one case though to make it more robust. When we explicitly pass service_region = null, then we get an error because I pass on [null] rather than null. Changing this line to

service_regions = try(each.value.service_region != null ? [each.value.service_region] : null, null)

should fix that and catch all cases (no service_region passed, service_region=null passed, valid service region passed). Will craete a PR for that.

@mmeidlinger mmeidlinger mentioned this pull request Jan 27, 2025
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmeidlinger @antonbabenko
0