-
-
Notifications
You must be signed in to change notification settings - Fork 37
feat: Support aws_opensearch_domain.node_options
#37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support aws_opensearch_domain.node_options
#37
Conversation
@@ -64,6 +64,16 @@ module "opensearch" { | |||
dedicated_master_type = "c6g.large.search" | |||
instance_type = "r6g.large.search" | |||
|
|||
node_options = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is quite right, did we try deploying this?
I think its:
node_options = {
node_type = "coordinator"
node_config = {
enabled = true
count = 3
type = "m6g.large.search"
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to deploy it successfully. It looked like node_options
is a list that could pass more than one set of options in the future (right now there's only coordinator
) so I made it accept either the key or a value in the list called node_type
. But I can change it if that seems unlikely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, lets try this
## [1.7.0](v1.6.0...v1.7.0) (2025-03-30) ### Features * Support `aws_opensearch_domain.node_options` ([#37](#37)) ([2a14c3f](2a14c3f))
This PR is included in version 1.7.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add support for Dedicated Coordinator Nodes.
Motivation and Context
hashicorp/terraform-provider-aws#40181
Breaking Changes
No.
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request