8000 docs: Correct typo in examples and README by ZeroOmar · Pull Request #34 · terraform-aws-modules/terraform-aws-opensearch · GitHub
[go: up one dir, main page]

Skip to content

docs: Correct typo in examples and README #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged

docs: Correct typo in examples and README #34

merged 1 commit into from
Dec 10, 2024

Conversation

ZeroOmar
Copy link
Contributor

Description

Fixed a typo in the example in the README.md and the examples/complete/main.tf files where the access_policy_statements conditions was written as condition

Motivation and Context

I was deploying an opensearch domain and didn't see any of my conditions appear in terraform plans. so I reviewed the code and found that the dynamic block condition was looking for statement.value.conditions

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@ZeroOmar ZeroOmar changed the title fix typo in examples and readme fix: corrected typo in examples and readme Dec 10, 2024
@ZeroOmar ZeroOmar changed the title fix: corrected typo in examples and readme fix: Corrected typo in examples and readme Dec 10, 2024
@bryantbiggs bryantbiggs changed the title fix: Corrected typo in examples and readme docs: Correct typo in examples and README Dec 10, 2024
@bryantbiggs bryantbiggs merged commit 9649166 into terraform-aws-modules:master Dec 10, 2024
9 of 11 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2025
@antonbabenko
Copy link
Member

This PR is included in version 1.6.0 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0