10000 Can we support RestartPolicy · Issue #230 · terraform-aws-modules/terraform-aws-ecs · GitHub
[go: up one dir, main page]
Skip to content

Can we support RestartPolicy #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RRosalia opened this issue Sep 15, 2024 · 7 comments · Fixed by #231
Closed

Can we support RestartPolicy #230

RRosalia opened this issue Sep 15, 2024 · 7 comments · Fixed by #231

Comments

@RRosalia
Copy link

Is your request related to a new offering from AWS? Yes ✅:

Is your request related to a problem? Please describe.

AWS ECS now supports restart policy to restart a container without restarting the whole tasks.

Describe the solution you'd like.

Implementation of: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/container-restart-policy-example.html

Describe alternatives you've considered.

None for now i just wait until this has been added.
@bryantbiggs
Copy link
Member

Does the Terraform provider support this?

@psantus
Copy link
psantus commented Sep 16, 2024

Yes it does! Since July it relies on SDK v2 and the Container Definition directly relies on SDK types.

I've tried it using vanilla provider and it works fine.

@psantus psantus mentioned this issue Sep 16, 2024
Merged
3 tasks
@psantus
Copy link
psantus commented Sep 16, 2024

@RRosalia coming soon :)

@psantus
Copy link
psantus commented Sep 16, 2024

@bryantbiggs I've opened a PR for this and completed all requirements (pre-commit hook and deployment)

@bryantbiggs
Copy link
Member

this is a recent addition and while its not apparent from the provider, its only available since August 15, 2024 https://aws.amazon.com/about-aws/whats-new/2024/08/amazon-ecs-restart-containers-task-relaunch/ (the container definition is not an actual Terraform resource currently, so its API is somewhat opaque and just accepts a json blob from the task definition or task set create API call)

Which means this requires the Terraform AWS provider of 5.63 at minimum

bryantbiggs added a commit that referenced this issue Sep 16, 2024
@psantus @bryantbiggs
feat: Add support for restartPolicy (#231)
2abd25f 
* feat: Add support for restartPolicy (#230)

* fix precommit error

* fix: Correct defaults and remove redundant validation

---------

Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
@bryantbiggs
Copy link
Member

resolved in #231 and will go out in v6.0

@github-actions GitHub Actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add support for restartPolicy
3 participants
@bryantbiggs @psantus @RRosalia
0