Fix typing for python JsonInferenceOutput #3761
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the typing for Python JsonInferenceOutput by ensuring that JSON inference outputs are properly wrapped in JsonInferenceOutput instances when converted to Python objects, rather than being returned as raw Python dictionaries.
- Replace direct conversion of JSON output to Python objects with proper JsonInferenceOutput class instantiation
- Add helper function to import JsonInferenceOutput class in Python bindings
- Add test coverage to verify the correct typing behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tensorzero-core/src/stored_inference.rs | Modified JSON output conversion to create JsonInferenceOutput instances with raw and parsed fields |
| tensorzero-core/src/inference/types/pyo3_helpers.rs | Added helper function to import JsonInferenceOutput class from Python module |
| clients/python/tests/test_rendering.py | Added test assertions to verify stored_output is JsonInferenceOutput instance |
| clients/python/src/lib.rs | Added JsonInferenceOutput class to Python module exports |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…ugfix-rendered-sample-stored-output-typing
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| raw: Option<String>, | ||
| parsed: Option<Bound<'_, PyAny>>, | ||
| ) -> PyResult<Self> { | ||
| use pyo3_helpers::deserialize_from_pyobj; |
There was a problem hiding this comment.
can we do this in the imports section? the typical way to do it is put
#[cfg(feature = "pyo3")]
use pyo3_helpers::deserialize_from_pyobj;
Pull request was converted to draft
Important
Improve typing for
JsonInferenceOutputin Python client, updating bindings, usage, and tests.JsonInferenceOutputclass to Python bindings inlib.rsandtensorzero.pyi.StoredInferenceandRenderedSampleto useJsonInferenceOutput.JsonInferenceOutputis correctly instantiated intest_rendering.py.JsonInferenceOutputtotensorzero/__init__.pyandtensorzero.pyi.deserialize_from_pyobjinpyo3_helpers.rsto handleJsonInferenceOutput.test_rendering.pyto testJsonInferenceOutputinstantiation and properties.JsonInferenceOutputis used in async and sync test cases.import_json_inference_outputfunction inpyo3_helpers.rs.stored_inference.rsto supportJsonInferenceOutput.This description was created by
for 2a59316. You can customize this summary. It will automatically update as commits are pushed.